Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create Project from Template set Project Type and Start Date #41309

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

fix: create Project from Template set Project Type and Start Date #41309

wants to merge 21 commits into from
+51 −24

Conversation

FHenry
Copy link
Contributor

@FHenry FHenry commented May 2, 2024 •
edited
Loading

Please provide enough information so that others can review your pull request:

Create Project Template of Project Type = Other
Create a Project from this template, Project Type is empty and start date is empty

As I was working on another PR (#41308) on Project DocType, github action show me this for semgreg failed result

frappe-semgrep-rules.rules.frappe-modifying-but-not-comitting-other-method
          self.copy_from_template is called from self.after_insert, check if changes to
          self.expected_start_date are commited to database.            

frappe-semgrep-rules.rules.frappe-modifying-but-not-comitting-other-method
          self.copy_from_template is called from self.after_insert, check if changes to self.project_type are
          commited to database.

Explain the details for making this change. What existing problem does the pull request solve?

Split method copy_from_template into two methods
copy_from_template_data : for project_type and default expected_start_date to today, call on before_insert and validate
copy_from_template_task : for tasks call on validate and after_insert

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 2, 2024
@FHenry FHenry mentioned this pull request May 3, 2024
Open
@FHenry FHenry force-pushed the dev_fix_semgreg branch from 08cd8a0 to b367688 Compare May 3, 2024 14:27
@FHenry FHenry marked this pull request as draft May 6, 2024 17:32
@FHenry FHenry marked this pull request as ready for review May 6, 2024 17:32
@FHenry
Copy link
Contributor Author

FHenry commented May 6, 2024 •
edited
Loading

Note to reviewer : I added tests after first commit, so label need-test is not accurate

@stale Stale

This comment has been minimized.

Sign in to view
@stale stale bot added the inactive label May 22, 2024
@stale stale bot removed the inactive label May 22, 2024
@FHenry
Copy link
Contributor Author

FHenry commented May 22, 2024

@deepeshgarg007 No reviewer auto-assign on this PR ? Could you have a look please ?

@stale Stale

This comment has been minimized.

Sign in to view
@stale stale bot added the inactive label Jun 24, 2024
@FHenry
Copy link
Contributor Author

FHenry commented Jun 24, 2024

@deepeshgarg007 No reviewer auto-assign on this PR ? Could you have a look please ?

@stale stale bot removed the inactive label Jun 24, 2024
@stale Stale

This comment has been minimized.

Sign in to view
@stale stale bot added the inactive label Jul 9, 2024
@stale stale bot removed the inactive label Jul 10, 2024
@stale Stale

This comment has been minimized.

Sign in to view
@stale stale bot added the inactive label Jul 27, 2024
@FHenry
Copy link
Contributor Author

FHenry commented Aug 14, 2024

Hello Frappe Team, there are no "auto-reviewer" for this PR affected by default.
Could you guide us to the best process, as this PR already respect the Contributing Guideline, to avoid this kind of "lost in loophole" for code contribution ?
On the other-hand, I understand that at Frappe, you have lot's of other important/critical PR to review.

@stale stale bot removed the inactive label Aug 14, 2024
@stale Stale

This comment has been minimized.

Sign in to view
@stale stale bot added the inactive label Sep 1, 2024
@stale stale bot removed the inactive label Sep 3, 2024
@stale Stale

This comment has been minimized.

Sign in to view
@stale stale bot added the inactive label Oct 5, 2024
@stale stale bot removed the inactive label Oct 5, 2024
@FHenry
Copy link
Contributor Author

FHenry commented Oct 5, 2024

@barredterra, @s-aga-r
Sorry to bother you both with this, but on theses two PRs #41308 and this one (they are linked), I didn't get any feedback from Frappe Team since a long time.
May be this is no interest on Project feature, could you just just tell me ?

@barredterra barredterra self-assigned this Oct 6, 2024
@barredterra barredterra added defer backport and removed needs-tests This PR needs automated unit-tests. labels Oct 8, 2024
@stale Stale

This comment was marked as outdated.

Sign in to view
@stale stale bot added the inactive label Oct 28, 2024
@stale Stale

This comment has been minimized.

Sign in to view
@stale stale bot added the inactive label Nov 16, 2024
@stale Stale
Copy link

stale bot commented Dec 20, 2024

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@barredterra barredterra

Labels
defer backport inactive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FHenry @barredterra